Repository navigation
feat: phase 2 stratigraphic column changes - #133
Open
lachlangrose wants to merge 10 commits into
Open
lachlangrose wants to merge 10 commits into
lachlangrose wants to merge 10 commits into
Conversation
Describe the current usability problems, a step-based dock, a direct interpolation entry, and derived data that is updated when its inputs change. Split the work into phases.
Add each toolbar action one time and call initProcessing one time. Show the fault adjacency instructions. Show one message for the basal contacts result. Show success results in the message bar. Ask for confirmation before the stratigraphic column is cleared. Delete the unused .ui files, and keep export_tab.ui for the export step.
Add shared layer roles (geology, unit field, fault traces, structure, basal contacts, DEM) and a contacts source setting. The map2loop tools show the roles as their default layers. Record a hash of the inputs of the basal contacts, the calculated thickness and the strat_order field. Show the out-of-date results in the stratigraphic column tab with an Update button. Record if a unit thickness was typed or calculated, and do not replace a typed thickness.
Put the geology layer first with a summary of the unit names that have no match. Use text buttons for adding units, a Build column menu and an overflow menu. Add Youngest and Oldest labels and a text for an empty column. Replace the three apply buttons with one Style map layer group. Use QgsColorButton and theme icons in the rows, and remove the outer scroll area.
QgsMessageBar.pushSuccess, pushInfo and pushWarning do not accept a duration argument. This caused a TypeError when a tool showed a success message.
…ic column UI branch Take the phase 1 fixes from abb6e57 and the CI changes from main. Keep the thickness tooltip and put back the outer scroll area of the tab.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of the usability plan. It is based on phase 1 (#132), so the base branch is
feat/shared-layer-roles. Change the base tomainafter #132 is merged.QgsColorButtonand a theme delete icon, and have no repeated "Thickness:" label. Unconformity rows have a different background.abb6e57), which includesmainwith the map highlight and thickness styling (feat(ui): highlight the stratigraphic unit on map when clicked in column #129) and the CI changes (ci: test on Python 3.10/3.12 and QGIS 3.44 LTR/4.2, use one line length, guard the pin bump #147).docs/usage/interface.mdand the plan are updated.Test plan
pytest testsin QGIS 3.42 (241 passed)🤖 Generated with Claude Code